Red Log Out button fix. #140
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
KittenSquad/glewlwyd!140
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "red-logout-button-fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
By analogy to its adjacent Continue button, the red Log Out button should only act on the current user.
I agree with the change. But I'm asking if a "Disconnect all users" button should be added somewhere, maybe in the navbar?
I imagine an admin having several login in a session and wants to disconnect them all for security reason, this could be helpful.
Something like that:
it could be hidden if there's only one user connected
@babelouest a killall button is always useful. But how extending your idea to include, instead, a nav-bar link to Manage Users (
/login.html?prompt=select_account)? I'd say the killall button belongs most naturally there. Also, in the navigation bar it is quite prone to accidental clicking...Incidentally, I'd also suggest rephrasing "New User" as "Add User" throughout. Currently it feels easy to conflate with "Register User".
Agreed for the
Manage usersentry, also the i18n already exists.Agreed too for the "Add user" label.
I'll push those changes directly in my master
Great. I'd suggest adding that link to both navigation bars (Admin and Profile). Your call, of course. 👍
That was the plan indeed
@yrammos , I've made the changes in my master branch, feel free to send feedbacks if you want!
@babelouest will do, meanwhile I'm trying to recover from an inexpicable (so far) "Glewlwyd API error" which prevents me from opening the webapp. The *nix service is running and restarting normally, my configuration files are in place and unchanged, building from source works with no errors… Restarted Apache, MySQL logs, … The Glewlwyd logs at
DEBUGlevel how no errors, either. Not opening an issue (yet) as I suspect this is a problem on my end (no branch or commit works!). I am one step short of restarting the server.@yrammos , open the javascript console (usually press on your browser), go to the network tab, then reload the page, you should see network connections in error, either 401, 404 or 500 errors usually, the error response body may be helpful to understand the cause.
If you're stuck, you can still open an issue, usually it's not a big deal...
@babelouest thank you, I had an unrelated server issue, now solved.
The new button and menu item look great; I wouldn't change a thing.
Would you agree that we need a button from
<PasswordForm>to<SelectAccount>? I think it is the only flow currently missing from the app. (Links in the reverse direction, on the other hand, are aplenty throughout the app).The button can be made visible only if
this.state.currentUseris non-empty. Happy to implement this tomorrow.I'll be happy to review and merge your PR!
I'd also like to know if you plan to request or implement other changes?
I don't have any constraints, but I'd like to release Glewlwyd 2.3 soon, I imagine some users may be happy with the upgrade.
I don't want to rush at all, I'll release when it's ready, therefore I'll be happy to release next version when you feel happy enough with it.
@babelwest, aside from the tiny wrinkle with the grants prompt (proposed in #136 but reverted), the only addition under my radar at the moment is a logout screen (discussed in #122). I haven’t come up with anything interesting. Dead ends make suitable pages for haikus—I have one by Kerouac on my GatsbyJS 404. But I’m reluctant to impose personal tastes. Some love Welsh epics, others Homeric :) How about starting with a generic “Session is closed,” which works equally well with single- and multiple-user sessions? Perhaps commit this small improvement in 1.3, aiming at tomorrow, then possibly evolve the feature in a 1.3.x or 1.4.
@yrammos ,
About the grants prompt, I reapplied your commit in a new branch and started a PR about it, see https://github.com/babelouest/glewlwyd/pull/141 , I need your help understanding what your initial goal was
Concerning the logout screen, I made a minimal one in the branch https://github.com/babelouest/glewlwyd/tree/logout-screen. The new page is already wired to the
Disconnect allin the Select Account page and the End session page available when the url has the parameterprompt=end_session(check OIDC session management if you're curious about that). I suggest to start from this branch for the improvements you might want to add. Feel free to send PR or open issues.