KittenSquad/glewlwyd
2
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

Clear admin logged out #122

Closed
yrammos wants to merge 2426 commits from clear-admin-logged-out into master
pull from: clear-admin-logged-out
merge into: KittenSquad:master
Conversation 6 Commits 2426 Files changed 3 +54 -50
yrammos commented 2020-06-08 10:10:02 +02:00 (Migrated from github.com)
Copy link

This PR is analogous to #121 (addressed by @babelouest in 919ab43). Its purpose is to clear the admin page navbar and main view if no admin user is logged in.

This PR is analogous to #121 (addressed by @babelouest in 919ab43). Its purpose is to clear the admin page navbar and main view if no admin user is logged in.
babelouest commented 2020-06-08 23:31:39 +02:00 (Migrated from github.com)
Copy link

Although I agree #121 was a good idea, I'm not sure having a blank page on the admin app when the user isn't logged in is a good idea, of target have at least some text, an image or a logo or something to appease the eye of the user rather than a cryptic page content. Do you have an idea on how to fill the void? On second thought, I'd also like something similar in the empty profile page too...

Although I agree #121 was a good idea, I'm not sure having a blank page on the admin app when the user isn't logged in is a good idea, of target have at least some text, an image or a logo or something to appease the eye of the user rather than a cryptic page content. Do you have an idea on how to fill the void? On second thought, I'd also like something similar in the empty profile page too...
yrammos commented 2020-06-09 01:51:16 +02:00 (Migrated from github.com)
Copy link

@babelouest I agree that a blank card view underneath a navbar makes for a cryptic logout experience. I've been meaning to suggest a prominent login button to fill that void elegantly and functionally (not just decoratively). The button on the far-right corner of the navbar is elegant but way too inconspicuous, especially for the non-admin user. How does this sound to you?

Meanwhile, I'll soon post a PR that improves the recent solution to #121 (profile page). Logging out currently empties only the "Personal data" pane but not the "Schemes" panes, potentially leaving sensitive TOTP tokens and other sensitive data exposed.

@babelouest I agree that a blank card view underneath a navbar makes for a cryptic logout experience. I've been meaning to suggest a prominent login button to fill that void elegantly and functionally (not just decoratively). The button on the far-right corner of the navbar is elegant but way too inconspicuous, especially for the non-admin user. How does this sound to you? Meanwhile, I'll soon post a PR that improves the recent solution to #121 (profile page). Logging out currently empties only the "Personal data" pane but not the "Schemes" panes, potentially leaving sensitive TOTP tokens and other sensitive data exposed.
babelouest commented 2020-06-09 02:15:49 +02:00 (Migrated from github.com)
Copy link

That's my problem here, my skills in we design are very low, so all I have is the idea to add something nice in the admin and profile page when logged out, not what, and even less how to do it. That's why I'm asking for help, if you have design skills :)

I've fixed the schemes data leak on logout in this commit: github.com/babelouest/glewlwyd@b46a9e25d2 , thanks for pointing out

That's my problem here, my skills in we design are very low, so all I have is the idea to add *something nice* in the admin and profile page when logged out, not what, and even less how to do it. That's why I'm asking for help, if you have design skills :) I've fixed the schemes data leak on logout in this commit: https://github.com/babelouest/glewlwyd/commit/b46a9e25d2dfacbe2c3769fae913575f2f8913c9 , thanks for pointing out
yrammos commented 2020-06-09 02:30:43 +02:00 (Migrated from github.com)
Copy link

@babelouest I'm not a designer by any stretch of the imagination but will try to put something together in the coming days.

I haven't checked b46a9e2 out yet but come think, it might expose the sessions list, if the accordion is left open. I've submitted PR that addresses the problem at the root, in case you may find it useful.

@babelouest I'm not a designer by any stretch of the imagination but will try to put something together in the coming days. I haven't checked b46a9e2 out yet but come think, it *might* expose the sessions list, if the accordion is left open. I've submitted PR that addresses the problem at the root, in case you may find it useful.
yrammos commented 2020-06-09 02:50:16 +02:00 (Migrated from github.com)
Copy link

Closing this for now, thank you. Will return with a proper log out view in due course.

Closing this for now, thank you. Will return with a proper log out view in due course.
👍 1 🎉 1
babelouest commented 2020-06-09 03:03:51 +02:00 (Migrated from github.com)
Copy link

If we can't make something shiny, maybe we can come with something original like a fortune message or riddles...

If we can't make something shiny, maybe we can come with something original like a fortune message or riddles...

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
can't reproduce

   
duplicate

   
help wanted

   
improvement

   
invalid

   
need info

   
question

   
wontfix
No labels
bug
can't reproduce
duplicate
help wanted
improvement
invalid
need info
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
KittenSquad/glewlwyd!122
No description provided.