[Issue] Register button not showing up #176

Closed
opened 2021-02-24 13:40:56 +01:00 by gergof · 3 comments
gergof commented 2021-02-24 13:40:56 +01:00 (Migrated from github.com)

Describe the issue
On the login form the register button doesn't show up.

To Reproduce

  • Create registration module
  • in config.json fill in the register field

Expected behavior
The button should show up

Additional context
The problem is caused by this line: github.com/babelouest/glewlwyd@f70a133ea9/webapp-src/src/Login/Buttons.js (L205)

It should be this.state.registration. A possible workaround is to add "registration": true into your config.json.

**Describe the issue** On the login form the register button doesn't show up. **To Reproduce** - Create registration module - in config.json fill in the `register` field **Expected behavior** The button should show up **Additional context** The problem is caused by this line: https://github.com/babelouest/glewlwyd/blob/f70a133ea9ff6af6d9ef6bcd504423e8a7c5007d/webapp-src/src/Login/Buttons.js#L205 It should be `this.state.registration`. A possible workaround is to add `"registration": true` into your config.json.
babelouest commented 2021-02-24 15:01:52 +01:00 (Migrated from github.com)

Hello @gergof ,

Did you use the register documentation to install and configure your registration plugin? There's a paragraph describing how to update the config.json file.

If this still not work, can you post your "register" field from your config.json file?

Hello @gergof , Did you use the register documentation to install and configure your registration plugin? There's a [paragraph describing](https://github.com/babelouest/glewlwyd/blob/master/docs/REGISTER.md#add-a-link-in-the-login-page) how to update the config.json file. If this still not work, can you post your `"register"` field from your `config.json` file?
gergof commented 2021-02-24 15:46:13 +01:00 (Migrated from github.com)

Yes, I've followed the description from there.

My config.json register field looks like this:

{
  "register": [{
    "name": "register",
    "message": "login.register-link",
    "reset-credentials-message": "login.reset-credentials-link"
  }]
}
Yes, I've followed the description from there. My config.json register field looks like this: ```json { "register": [{ "name": "register", "message": "login.register-link", "reset-credentials-message": "login.reset-credentials-link" }] } ```
babelouest commented 2021-02-24 20:06:49 +01:00 (Migrated from github.com)

Thanks again @gergof , your first assumption was correct, it's probably a regression introduced some time ago. I fixed the bug ere: github.com/babelouest/glewlwyd@6a0f7752ec

Thanks again @gergof , your first assumption was correct, it's probably a regression introduced some time ago. I fixed the bug ere: https://github.com/babelouest/glewlwyd/commit/6a0f7752ec683b4a96bfc4e3f578a4e9147703c1
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
KittenSquad/glewlwyd#176
No description provided.